Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support create table as select #6102

Merged
merged 10 commits into from Sep 10, 2021
Merged

Support create table as select #6102

merged 10 commits into from Sep 10, 2021

Conversation

stalary
Copy link
Contributor

@stalary stalary commented Jun 27, 2021 •
edited

Proposed changes

Support create table as select...，This statement is handy for building ADS tables

The decimal type is not currently supported

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Fix #6101

@stalary
Copy link
Contributor Author

stalary commented Jun 28, 2021

wait support string

@yangzhg
Copy link
Member

yangzhg commented Aug 23, 2021

wait support string

String type has been merged

@stalary
Copy link
Contributor Author

stalary commented Aug 23, 2021

wait support string

String type has been merged

Ok, I will support it as soon as possible

@morningman morningman changed the title WIP: 添加create table as select WIP: Support create table as select Aug 31, 2021
@stalary stalary changed the title WIP: Support create table as select Support create table as select Sep 6, 2021
@morningman morningman added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 6, 2021
morningman
morningman reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please resolve the conflict

morningman
morningman approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

PR approved by anyone and no changes requested.

@yangzhg yangzhg merged commit 2c58724 into apache:master Sep 10, 2021
@morningman morningman mentioned this pull request Oct 10, 2021
Closed
@stalary stalary deleted the create_table_as branch May 8, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support create table as select...
3 participants
@stalary @yangzhg @morningman