Fix a problem which may cause nullptr in ResultBufferMgr#882
Merged
Conversation
Because there is no lock in the middle call to findBlock(), even if the first call returns non-null, the second call may still get a null block
morningman
approved these changes
Apr 6, 2019
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Nov 4, 2022
* Implement create tablets in batch * Batch create tablet in sc and rollup * Remove useless code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because there is no lock in the middle call to findBlock(),
even if the first call returns non-null, the second call
may still get a null block
ISSUE: #883