Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More coordinator automated testing #5623

Closed
jon-wei opened this issue Apr 10, 2018 · 5 comments

Comments

@jon-wei
Copy link
Contributor

commented Apr 10, 2018

We've had quite a few coordinator bug fixes recently, e.g.:
#5554
#5532
#5529
#5528

Based on this, I think It's probably good idea for us to develop some more tests around coordinator behavior, at least for the following areas:

  • Coordinator leadership changes (to help catch bugs like the one fixed by #5554)
  • Segment balancing behavior
@EungsopYoo

This comment has been minimized.

Copy link

commented Apr 11, 2018

I think it would be better to add some performance regression tests.
We got a performance regression of coordinator in 0.12.0.
It will be reported soon.

@jihoonson

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

@EungsopYoo I believe this issue is about adding a test environment for testing coodinator functionalities. But, performance regression test also sounds good. Would you raise a new issue for it?

@EungsopYoo

This comment has been minimized.

Copy link

commented Apr 12, 2018

@jihoonson
My colleague will do. It is caused by use of Collection.contains() and is revealed a problem when we have above 200k segments.

@stale

This comment has been minimized.

Copy link

commented Jun 21, 2019

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
@stale

This comment has been minimized.

Copy link

commented Jul 5, 2019

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@stale stale bot closed this Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.