Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright. #5835
Files with a non-standard header (by Druid standards):
The license on the these three files seems ok (it's Apache 2.0) and also we already call this copying out in the NOTICE file. So they seem ok to me but I'm just calling them out to double-check.
We also have two files with no license header:
In that issue, @fjy said:
I can't find the original source of the Concise library. The paper is at https://arxiv.org/pdf/1004.0403.pdf, which links to source at http://concise.svn.sourceforge.net/viewvc/concise?view=rev&revision=1; however, that link is dead. However, I did some digging and found this commit: metamx/extendedset@02366f1#diff-97bd266eb5d2e8b0e7a38a658921356d. So it looks like these files with no headers were created in a refactor with code largely taken from ConciseSet (which is Apache licensed). So, that's good.
What's the best way to move forward here? Could we leave the first three files as-is, and add identical, nonstandard headers to the other two files describing where they came from and that they are Apache licensed?