New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright. #5835

Open
drcrallen opened this Issue May 31, 2018 · 1 comment

Comments

2 participants
@drcrallen
Contributor

drcrallen commented May 31, 2018

@drcrallen drcrallen added the Apache label May 31, 2018

@drcrallen drcrallen added this to To do in Apache Incubation May 31, 2018

@drcrallen drcrallen self-assigned this May 31, 2018

@drcrallen drcrallen moved this from To do to In progress in Apache Incubation Jun 9, 2018

@gianm

This comment has been minimized.

Show comment
Hide comment
@gianm

gianm Jul 11, 2018

Contributor

#5976 updated almost all source files. There are a small number that were not updated: #5976 (comment). We can close this issue when those are figured out.

Files with a non-standard header (by Druid standards):

The license on the these three files seems ok (it's Apache 2.0) and also we already call this copying out in the NOTICE file. So they seem ok to me but I'm just calling them out to double-check.

We also have two files with no license header:

In that issue, @fjy said:

ConciseSetUtils is from the original ConciseSet library under the Apache license. The license header is missing for the file but it should be the same as the rest of the files under the ConciseSet library (Apache v2).

And:

IntList is from the same place

I can't find the original source of the Concise library. The paper is at https://arxiv.org/pdf/1004.0403.pdf, which links to source at http://concise.svn.sourceforge.net/viewvc/concise?view=rev&revision=1; however, that link is dead. However, I did some digging and found this commit: metamx/extendedset@02366f1#diff-97bd266eb5d2e8b0e7a38a658921356d. So it looks like these files with no headers were created in a refactor with code largely taken from ConciseSet (which is Apache licensed). So, that's good.

What's the best way to move forward here? Could we leave the first three files as-is, and add identical, nonstandard headers to the other two files describing where they came from and that they are Apache licensed?

Contributor

gianm commented Jul 11, 2018

#5976 updated almost all source files. There are a small number that were not updated: #5976 (comment). We can close this issue when those are figured out.

Files with a non-standard header (by Druid standards):

The license on the these three files seems ok (it's Apache 2.0) and also we already call this copying out in the NOTICE file. So they seem ok to me but I'm just calling them out to double-check.

We also have two files with no license header:

In that issue, @fjy said:

ConciseSetUtils is from the original ConciseSet library under the Apache license. The license header is missing for the file but it should be the same as the rest of the files under the ConciseSet library (Apache v2).

And:

IntList is from the same place

I can't find the original source of the Concise library. The paper is at https://arxiv.org/pdf/1004.0403.pdf, which links to source at http://concise.svn.sourceforge.net/viewvc/concise?view=rev&revision=1; however, that link is dead. However, I did some digging and found this commit: metamx/extendedset@02366f1#diff-97bd266eb5d2e8b0e7a38a658921356d. So it looks like these files with no headers were created in a refactor with code largely taken from ConciseSet (which is Apache licensed). So, that's good.

What's the best way to move forward here? Could we leave the first three files as-is, and add identical, nonstandard headers to the other two files describing where they came from and that they are Apache licensed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment