New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain Avro's unnecessary EOFException (#4098) #4100

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
3 participants
@asdf2014
Member

asdf2014 commented Mar 23, 2017

Explain Avro's unnecessary EOFException (#4098)

We should change the version of Avro from 1.7.7 into the 1.9.0 when it released, but right now we should explain it in log and fix it with patch, because it hurts the performance of Avro-Extension very.

@gianm

This comment has been minimized.

Contributor

gianm commented Mar 24, 2017

@asdf2014 thanks for the contribution! That's a strange avro bug. Could you include the JIRA link in the exception message too? That way, a user would see it without having to read the Druid code. 👍 from me after that.

Also, could you please fill out the CLA here: http://druid.io/community/cla.html

@@ -87,6 +86,10 @@ public GenericRecord parse(ByteBuffer bytes)
try {
return reader.read(null, DecoderFactory.get().binaryDecoder(inputStream, null));
}
catch (EOFException eof) {
// waiting for avro v1.9.0 (#AVRO-813)
throw new ParseException("Avro's unnecessary EOFException", eof);

This comment has been minimized.

@gianm

gianm Mar 24, 2017

Contributor

Please include the JIRA link in this message and others like it.

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Mar 24, 2017

@gianm Already add the jira link into log message. It's my pleasure, i have filled out the individual CLA.

@himanshug

This comment has been minimized.

Contributor

himanshug commented Mar 24, 2017

👍

@himanshug himanshug merged commit 23f77eb into apache:master Mar 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gianm gianm added this to the 0.10.1 milestone Jul 6, 2017

@asdf2014 asdf2014 deleted the asdf2014:avro_eof branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment