Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inefficient available segment cache population in SQLMetadataSegmentManager #5878

Merged
merged 1 commit into from Jun 13, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -85,6 +85,14 @@ public ImmutableDruidDataSource toImmutableDruidDataSource()
return new ImmutableDruidDataSource(name, properties, idToSegmentMap);
}

// For performance reasons, make sure we check for the existence of a segment using containsSegment(),
// which performs a key-based lookup, instead of calling contains() on the collection returned by
// dataSource.getSegments(). In Map values collections, the contains() method is a linear scan.
public boolean containsSegment(DataSegment segment)
{
return idToSegmentMap.containsKey(segment.getIdentifier());
}

@Override
public String toString()
{
@@ -475,7 +475,10 @@ public DataSegment map(int index, ResultSet r, StatementContext ctx)
}
}

if (!dataSource.getSegments().contains(segment)) {
// For performance reasons, make sure we check for the existence of a segment using containsSegment(),
// which performs a key-based lookup, instead of calling contains() on the collection returned by
// dataSource.getSegments(). In Map values collections, the contains() method is a linear scan.
if (!dataSource.containsSegment(segment)) {
dataSource.addSegment(segment);
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.