New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong counter getFailedSendingTimeCounter method #6793

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@asdf2014
Copy link
Member

asdf2014 commented Jan 2, 2019

Fix #6788

@nishantmonu51
Copy link
Member

nishantmonu51 left a comment

Thanks for the patch, 👍, It would be awesome if you can also add a unit test.

@asdf2014

This comment has been minimized.

Copy link
Member

asdf2014 commented Jan 2, 2019

Hi, @nishantmonu51 . Thanks for your comments. It's done. PTAL.

@nishantmonu51

This comment has been minimized.

Copy link
Member

nishantmonu51 commented Jan 2, 2019

Thanks @asdf2014

@QiuMM

QiuMM approved these changes Jan 2, 2019

@QiuMM QiuMM merged commit e8ddd99 into apache:master Jan 2, 2019

2 checks passed

Inspections: pull requests (Druid) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asdf2014 asdf2014 deleted the asdf2014:fix_failed_sending_time_counter branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment