Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide descriptive comments in `pull_request_template.md` #8313

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@asdf2014
Copy link
Member

commented Aug 15, 2019

Description

Hide descriptive comments in pull_request_template.md.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 requested a review from leventov Aug 15, 2019

@asdf2014 asdf2014 added the Area - Dev label Aug 15, 2019

@asdf2014 asdf2014 merged commit 399b3ad into apache:master Aug 16, 2019

2 checks passed

Inspections: pull requests (Druid) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asdf2014 asdf2014 deleted the asdf2014:imporve_pr branch Aug 16, 2019

@clintropolis clintropolis added this to the 0.16.0 milestone Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.