Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grade shield #8344

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@asdf2014
Copy link
Member

commented Aug 20, 2019

Description

Add grade shield Language grade: Java, more details: #8337 (comment)


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@Fokko
Fokko approved these changes Aug 20, 2019
Copy link
Contributor

left a comment

Love it!

@ccaominh
Copy link
Contributor

left a comment

LGTM! 👍

@gianm

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@asdf2014, apologies for introducing conflicts by merging #8303. Could you please fix them up -- afterwards this looks good to go.

@asdf2014 asdf2014 force-pushed the asdf2014:add_grade_shield branch from 4f0ca4a to 0fe4efa Aug 21, 2019

@asdf2014 asdf2014 merged commit c4db836 into apache:master Aug 21, 2019

2 of 6 checks passed

Inspections: pull requests (Druid) TeamCity build started
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.9%) to 68.273%
Details

@asdf2014 asdf2014 deleted the asdf2014:add_grade_shield branch Aug 21, 2019

@clintropolis clintropolis added this to the 0.16.0 milestone Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.