Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing space in string literal and spurious Javadoc @param tags from LGTM #8491

Merged
merged 2 commits into from Sep 16, 2019

Conversation

@asdf2014
Copy link
Member

commented Sep 9, 2019

Description

Fix missing space in string literal and spurious Javadoc @param tags from LGTM


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@lgtm-com

This comment has been minimized.

Copy link

commented Sep 9, 2019

This pull request fixes 4 alerts when merging aad95c3 into 2b04c22 - view on LGTM.com

fixed alerts:

  • 2 for Spurious Javadoc @param tags
  • 2 for Missing space in string literal

@asdf2014 asdf2014 added the Improvement label Sep 9, 2019

@waywtd

This comment has been minimized.

Copy link

commented Sep 9, 2019

666

@ccaominh
Copy link
Contributor

left a comment

LGTM 👍

@nishantmonu51
Copy link
Member

left a comment

👍

@nishantmonu51 nishantmonu51 merged commit c6f4f09 into apache:master Sep 16, 2019

3 of 5 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Inspections: pull requests (Druid) TeamCity build finished
Details
LGTM analysis: Java 4 fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asdf2014 asdf2014 deleted the asdf2014:fix_recommendations branch Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.