New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created English version of echarts-all.js file, would like to contribute file to ECharts #2321

Closed
WebCodePro719 opened this Issue Jan 2, 2016 · 16 comments

Comments

Projects
None yet
@WebCodePro719

WebCodePro719 commented Jan 2, 2016

Hello, I've created an English version of the echarts-all.js file and would like to contribute it to the ECharts GitHub repository. Using Google Translate, I've translated the chart tooltips and title tags to English. I've also included some additional themes in the echarts-all.js file (the original file only includes default, infographic and macarons themes). If you find that this updated echarts-all.js file is helpful, perhaps it could be made available for download along with the original Chinese version. I've also included a couple bar chart examples in the zip. I wasn't sure if I should make a pull request to submit this to ECharts since the changes are significant. I really like ECharts, thanks for making it open source. Hopefully this English version of echarts-all.js file is helpful.
EChartsAll-English.zip

@adi76

This comment has been minimized.

Show comment
Hide comment
@adi76

adi76 commented Apr 20, 2016

thanks

@oguzozgen

This comment has been minimized.

Show comment
Hide comment
@oguzozgen

oguzozgen commented Dec 27, 2016

ty

@markopill

This comment has been minimized.

Show comment
Hide comment
@markopill

markopill Jan 9, 2017

thanks, very helpful

markopill commented Jan 9, 2017

thanks, very helpful

@pissang pissang closed this Apr 4, 2017

@annjawn

This comment has been minimized.

Show comment
Hide comment
@annjawn

annjawn Apr 30, 2017

Is there a future roadmap to support multiple languages through global default options?

annjawn commented Apr 30, 2017

Is there a future roadmap to support multiple languages through global default options?

@KugonicU

This comment has been minimized.

Show comment
Hide comment
@KugonicU

KugonicU Jun 19, 2017

Thanks a lot. Save a lot of hours of work!

KugonicU commented Jun 19, 2017

Thanks a lot. Save a lot of hours of work!

@dyve

This comment has been minimized.

Show comment
Hide comment
@dyve

dyve Jul 8, 2017

I would love multiple languages (translatable strings or a simple JS associative array).

dyve commented Jul 8, 2017

I would love multiple languages (translatable strings or a simple JS associative array).

@EgleKat

This comment has been minimized.

Show comment
Hide comment
@EgleKat

EgleKat Jul 26, 2017

How do I add it to the library, it doesn't seem to work for me

EgleKat commented Jul 26, 2017

How do I add it to the library, it doesn't seem to work for me

@100pah 100pah added the enhancement label Jul 28, 2017

@WebCodePro719

This comment has been minimized.

Show comment
Hide comment
@WebCodePro719

WebCodePro719 Jul 29, 2017

@EgleKat Copy the theme JS file(s) into the folder called "theme." Make sure the name of the theme is added to the chart code (2 places).

WebCodePro719 commented Jul 29, 2017

@EgleKat Copy the theme JS file(s) into the folder called "theme." Make sure the name of the theme is added to the chart code (2 places).

@zherman91

This comment has been minimized.

Show comment
Hide comment
@zherman91

zherman91 Feb 6, 2018

Hello. I just tried this last night and its working however, my color scheme went away and was replaced with pinks and blues and I'm not sure how to adjust this. I'm new to echarts so i most likely missed something small. Can anyone help?

zherman91 commented Feb 6, 2018

Hello. I just tried this last night and its working however, my color scheme went away and was replaced with pinks and blues and I'm not sure how to adjust this. I'm new to echarts so i most likely missed something small. Can anyone help?

@WebCodePro719

This comment has been minimized.

Show comment
Hide comment
@WebCodePro719

WebCodePro719 Feb 8, 2018

Hi @zherman91 - it's hard to figure out what is causing the problem without seeing your code. But it could be a problem with the line of JS code where you add the theme. For example the default code is this:

var myChart = echarts.init(document.getElementById('main')); myChart.setOption({

If you want to add a theme, then the code would be something like this:

var myChart = echarts.init(document.getElementById('main'), 'green'); myChart.setOption({

I'm assuming you're using ECharts version 2 in this case. The themes for ECharts 3.0 are installed differently. There are separate JS files for the themes in version 3.

WebCodePro719 commented Feb 8, 2018

Hi @zherman91 - it's hard to figure out what is causing the problem without seeing your code. But it could be a problem with the line of JS code where you add the theme. For example the default code is this:

var myChart = echarts.init(document.getElementById('main')); myChart.setOption({

If you want to add a theme, then the code would be something like this:

var myChart = echarts.init(document.getElementById('main'), 'green'); myChart.setOption({

I'm assuming you're using ECharts version 2 in this case. The themes for ECharts 3.0 are installed differently. There are separate JS files for the themes in version 3.

@annjawn

This comment has been minimized.

Show comment
Hide comment
@annjawn

annjawn Feb 8, 2018

@zherman91 check what theme you are using. I am pretty sure it's the theme that is causing the colors.

annjawn commented Feb 8, 2018

@zherman91 check what theme you are using. I am pretty sure it's the theme that is causing the colors.

@annjawn

This comment has been minimized.

Show comment
Hide comment
@annjawn

annjawn Feb 8, 2018

BTW @WebCodePro719 , we've been using your english version in our internal environments for almost a year now and it's still going strong. Thanks again!

annjawn commented Feb 8, 2018

BTW @WebCodePro719 , we've been using your english version in our internal environments for almost a year now and it's still going strong. Thanks again!

@zherman91

This comment has been minimized.

Show comment
Hide comment
@zherman91

zherman91 Feb 8, 2018

@WebCodePro719 - Thanks so much for the reply! I will give this a shot but I'm pretty sure that's what i was missing. Thanks again!

zherman91 commented Feb 8, 2018

@WebCodePro719 - Thanks so much for the reply! I will give this a shot but I'm pretty sure that's what i was missing. Thanks again!

@zherman91

This comment has been minimized.

Show comment
Hide comment
@zherman91

zherman91 Feb 8, 2018

@WebCodePro719 - Thanks so much for the reply! I will give this a shot but I'm pretty sure that's what i was missing. Thanks again!

zherman91 commented Feb 8, 2018

@WebCodePro719 - Thanks so much for the reply! I will give this a shot but I'm pretty sure that's what i was missing. Thanks again!

@WebCodePro719

This comment has been minimized.

Show comment
Hide comment
@WebCodePro719

WebCodePro719 Feb 9, 2018

@annjawn that's great to hear - I'm glad this file has been helpful.

WebCodePro719 commented Feb 9, 2018

@annjawn that's great to hear - I'm glad this file has been helpful.

@WebCodePro719

This comment has been minimized.

Show comment
Hide comment
@WebCodePro719

WebCodePro719 Feb 9, 2018

@zherman91 No problem, I hope you figure it out.

WebCodePro719 commented Feb 9, 2018

@zherman91 No problem, I hope you figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment