New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

命名规范 #6788

Closed
limerickgds opened this Issue Sep 30, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@limerickgds

limerickgds commented Sep 30, 2017

One-line summary [问题简述]

https://github.com/ecomfe/echarts/blob/master/src/component/toolbox/ToolboxView.js#L41
函数名为 process 。
webpack production 打包,会将 process 优化为

{
  env: {
    NODE_ENV: 'production'
  }
}

所以编译报错。

Expected behaviour [期望结果]

规范一下函数命名。建议修改函数名

@pissang pissang added the bug label Oct 9, 2017

@Ovilia Ovilia closed this in 0af210f Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment