From 51e65f8f20611156ecc23e487b28ed545975bfd3 Mon Sep 17 00:00:00 2001 From: uce Date: Mon, 16 Jun 2014 22:17:48 +0200 Subject: [PATCH] [FLINK-942] Fix bug in config.sh to correctly set user-specified JVM args --- stratosphere-dist/src/main/stratosphere-bin/bin/config.sh | 6 +++--- .../src/main/stratosphere-bin/bin/jobmanager.sh | 2 +- .../src/main/stratosphere-bin/bin/taskmanager.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/stratosphere-dist/src/main/stratosphere-bin/bin/config.sh b/stratosphere-dist/src/main/stratosphere-bin/bin/config.sh index bd6c30281cc6b..916881358e8bb 100755 --- a/stratosphere-dist/src/main/stratosphere-bin/bin/config.sh +++ b/stratosphere-dist/src/main/stratosphere-bin/bin/config.sh @@ -167,12 +167,12 @@ if [ -z "${STRATOSPHERE_PID_DIR}" ]; then STRATOSPHERE_PID_DIR=$(readFromConfig ${KEY_ENV_PID_DIR} "${DEFAULT_ENV_PID_DIR}" "${YAML_CONF}") fi -if [ -z "${STRATOSPHERE_OPTS}" ]; then - STRATOSPHERE_OPTS=$(readFromConfig ${KEY_ENV_JAVA_OPTS} "${DEFAULT_ENV_JAVA_OPTS}" "${YAML_CONF}") +if [ -z "${STRATOSPHERE_ENV_JAVA_OPTS}" ]; then + STRATOSPHERE_ENV_JAVA_OPTS=$(readFromConfig ${KEY_ENV_JAVA_OPTS} "${DEFAULT_ENV_JAVA_OPTS}" "${YAML_CONF}") fi if [ -z "${STRATOSPHERE_SSH_OPTS}" ]; then - STRATOSPHERE_OPTS=$(readFromConfig ${KEY_ENV_SSH_OPTS} "${DEFAULT_ENV_SSH_OPTS}" "${YAML_CONF}") + STRATOSPHERE_SSH_OPTS=$(readFromConfig ${KEY_ENV_SSH_OPTS} "${DEFAULT_ENV_SSH_OPTS}" "${YAML_CONF}") fi # Arguments for the JVM. Used for job and task manager JVMs. diff --git a/stratosphere-dist/src/main/stratosphere-bin/bin/jobmanager.sh b/stratosphere-dist/src/main/stratosphere-bin/bin/jobmanager.sh index d41874c3f2653..e474e5eeb75b2 100755 --- a/stratosphere-dist/src/main/stratosphere-bin/bin/jobmanager.sh +++ b/stratosphere-dist/src/main/stratosphere-bin/bin/jobmanager.sh @@ -72,7 +72,7 @@ case $STARTSTOP in rotateLogFile $out echo Starting job manager - $JAVA_RUN $JVM_ARGS $STRATOSPHERE_OPTS "${log_setting[@]}" -classpath "$STRATOSPHERE_JM_CLASSPATH" eu.stratosphere.nephele.jobmanager.JobManager -executionMode $EXECUTIONMODE -configDir "$STRATOSPHERE_CONF_DIR" > "$out" 2>&1 < /dev/null & + $JAVA_RUN $JVM_ARGS $STRATOSPHERE_ENV_JAVA_OPTS "${log_setting[@]}" -classpath "$STRATOSPHERE_JM_CLASSPATH" eu.stratosphere.nephele.jobmanager.JobManager -executionMode $EXECUTIONMODE -configDir "$STRATOSPHERE_CONF_DIR" > "$out" 2>&1 < /dev/null & echo $! > $pid ;; diff --git a/stratosphere-dist/src/main/stratosphere-bin/bin/taskmanager.sh b/stratosphere-dist/src/main/stratosphere-bin/bin/taskmanager.sh index 0800be60a591a..ea6e46887ce59 100755 --- a/stratosphere-dist/src/main/stratosphere-bin/bin/taskmanager.sh +++ b/stratosphere-dist/src/main/stratosphere-bin/bin/taskmanager.sh @@ -69,7 +69,7 @@ case $STARTSTOP in rotateLogFile $out echo Starting task manager on host $HOSTNAME - $JAVA_RUN $JVM_ARGS $STRATOSPHERE_OPTS "${log_setting[@]}" -classpath "$STRATOSPHERE_TM_CLASSPATH" eu.stratosphere.nephele.taskmanager.TaskManager -configDir "$STRATOSPHERE_CONF_DIR" > "$out" 2>&1 < /dev/null & + $JAVA_RUN $JVM_ARGS $STRATOSPHERE_ENV_JAVA_OPTS "${log_setting[@]}" -classpath "$STRATOSPHERE_TM_CLASSPATH" eu.stratosphere.nephele.taskmanager.TaskManager -configDir "$STRATOSPHERE_CONF_DIR" > "$out" 2>&1 < /dev/null & echo $! > $pid ;;