From 68e89b015e05ab61f23ed072a36c293338df4163 Mon Sep 17 00:00:00 2001 From: Jia Ke Date: Wed, 15 May 2024 17:23:21 +0800 Subject: [PATCH] Fix compile issue --- cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc index cd11be304b63..3de1c7562283 100644 --- a/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc +++ b/cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc @@ -619,13 +619,15 @@ bool SubstraitToVeloxPlanValidator::validate(const ::substrait::WindowRel& windo bool resolved = false; for (const auto& signature : signaturesOpt.value()) { // The rank like functions don't need argument. - if (rankLikeNames.find(funcName) != rankLikeNames.end()) { + if (std::find(rankLikeNames.begin(), rankLikeNames.end(), funcName) != rankLikeNames.end()) { types.clear(); } + // The lead and lag argument only need the first element. - if (leadLagNames.find(funcName) != leadLagNames.end()) { + if (std::find(leadLagNames.begin(), leadLagNames.end(), funcName) != leadLagNames.end()) { types.resize(1); } + exec::SignatureBinder binder(*signature, types); if (binder.tryBind()) { auto type = binder.tryResolveType(signature->returnType());