Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-868] Check flow status instead of job status to determine if flow is running #2723

Closed
wants to merge 2 commits into from

Conversation

@jack-moseley
Copy link
Contributor

jack-moseley commented Sep 5, 2019

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

After updating to use flow level events for job status, this code should be using the flow level status instead of using jobs.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
@jack-moseley

This comment has been minimized.

Copy link
Contributor Author

jack-moseley commented Sep 5, 2019

@arjun4084346 please review

@arjun4084346

This comment has been minimized.

Copy link
Contributor

arjun4084346 commented Sep 5, 2019

+1

@jack-moseley

This comment has been minimized.

Copy link
Contributor Author

jack-moseley commented Sep 5, 2019

@sv2000 please merge

@sv2000

This comment has been minimized.

Copy link
Contributor

sv2000 commented Sep 6, 2019

@jack-moseley travis failed. can you check?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #2723 into master will increase coverage by <.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2723      +/-   ##
============================================
+ Coverage     45.01%   45.01%   +<.01%     
- Complexity     8740     8744       +4     
============================================
  Files          1884     1884              
  Lines         70266    70267       +1     
  Branches       7709     7710       +1     
============================================
+ Hits          31628    31634       +6     
+ Misses        35709    35703       -6     
- Partials       2929     2930       +1
Impacted Files Coverage Δ Complexity Δ
...gobblin/service/monitoring/JobStatusRetriever.java 0% <0%> (ø) 2 <2> (+2) ⬆️
...org/apache/gobblin/service/FlowStatusResource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...obblin/service/monitoring/FlowStatusGenerator.java 82.14% <100%> (-7.15%) 11 <1> (-1)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 66.19% <0%> (+0.46%) 29% <0%> (ø) ⬇️
...in/java/org/apache/gobblin/cluster/HelixUtils.java 39.25% <0%> (+3.73%) 13% <0%> (+1%) ⬆️
...lin/util/filesystem/FileSystemInstrumentation.java 92.85% <0%> (+7.14%) 3% <0%> (ø) ⬇️
...g/apache/gobblin/service/monitoring/JobStatus.java 23.52% <0%> (+11.76%) 4% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3523dbc...bb1564d. Read the comment docs.

@sv2000
sv2000 approved these changes Sep 6, 2019
Copy link
Contributor

sv2000 left a comment

+1. LGTM.

@asfgit asfgit closed this in 4eb8a27 Sep 6, 2019
Will-Lo pushed a commit to Will-Lo/incubator-gobblin that referenced this pull request Sep 18, 2019
… flow is running

Closes apache#2723 from jack-moseley/flowstatus-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.