Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWQ-1183. Writable external table with Hash distribution shows slow … #1033

Closed
wants to merge 1 commit into from

Conversation

paul-guo-
Copy link
Contributor

…performance

This fixes some warnings also in the affected source file.

Copy link
Member

@xunzhang xunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you write some test cases for this pull request? Does this change modify heap table?

@paul-guo-
Copy link
Contributor Author

I thought adding a case, but it seems that it is hard to add one in the current framework.

@xunzhang
Copy link
Member

xunzhang commented Dec 2, 2016

ok, maybe we could test it manually for this.

@paul-guo-
Copy link
Contributor Author

@zhangh43

…performance

This fixes some warnings also in the affected source file.
@paul-guo-
Copy link
Contributor Author

@huor

@zhangh43
Copy link
Contributor

zhangh43 commented Dec 5, 2016

+1 for external table bucket number change.

@huor
Copy link
Contributor

huor commented Dec 5, 2016

+1

@paul-guo-
Copy link
Contributor Author

Merged.

@paul-guo- paul-guo- closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants