From 1143acb133fc695b0f71d238a35a60c331c3eaad Mon Sep 17 00:00:00 2001 From: deem0n Date: Sat, 13 Jan 2018 11:49:55 +0300 Subject: [PATCH] HAWQ-1579. Fix pxf logging issue with null Metadata When you enable DEBUG logging you might get annoying exceptions: ``` SEVERE: The RuntimeException could not be mapped to a response, re-throwing to the HTTP container java.lang.NullPointerException at java.lang.String.(String.java:566) at org.apache.hawq.pxf.service.FragmentsResponseFormatter.printList(FragmentsResponseFormatter.java:147) at org.apache.hawq.pxf.service.FragmentsResponseFormatter.formatResponse(FragmentsResponseFormatter.java:54) at org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:88) ``` I just added the trivial fix. --- .../apache/hawq/pxf/service/FragmentsResponseFormatter.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/FragmentsResponseFormatter.java b/pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/FragmentsResponseFormatter.java index 14e87f9b5e..9136007b15 100644 --- a/pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/FragmentsResponseFormatter.java +++ b/pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/FragmentsResponseFormatter.java @@ -143,8 +143,10 @@ private static void printList(List fragments, String datapath) { result.append(" ").append(host); } - result.append(", Metadata: ").append( + if (fragment.getMetadata() != null) { + result.append(", Metadata: ").append( new String(fragment.getMetadata())); + } if (fragment.getUserData() != null) { result.append(", User Data: ").append(