HAWQ-1051. Failing in reverse DNS lookup causes resource manager core… #928
Conversation
| { | ||
| elog(WARNING, "Failed to reverse DNS lookup for ip %s.", fts_client_ip); | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
If it is easy to modify we could use the replacement of gethostbyaddr().
By the way, why need to quit after "reverse dns lookup" failure. Should not
an IP address work also?
DESCRIPTION
The gethostbyname_() and gethostbyaddr_() functions are obsolete. Applications
should use getaddrinfo(3) and getnameinfo(3) instead.
There was a problem hiding this comment.
Not quit after "reverse dns lookup" failure. This function handles the IMAlive message from segment resource manager process. "return true" just ignore this message and do not continue the followup work after a lookup failure. IP address is not enough since followup work needs the hostname.
For replace gethostbyaddr(), @jiny2 could you give some comments ?
|
It would be great if the commit message can be updated to include both stanlyxiang and jiny2 as author. |
|
@huor Could you give a commit example like this? |
|
@xunzhang, here is a tool with that support: https://github.com/git-duet/git-duet. You can also find the example in page home page. |
… dump Signed-off-by: jiny2 <yjin@pivotal.io>
stanlyxiang
force-pushed
the
reversefail
branch
from
0f5cec0
to
3e48b0b
Compare
|
Merged. |
… dump