Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

[HIVEMALL-28] Set HIVEMALL_HOME to absolute path #20

Closed
wants to merge 1 commit into from
Closed

[HIVEMALL-28] Set HIVEMALL_HOME to absolute path #20

wants to merge 1 commit into from

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Jan 19, 2017

What does this pull request solve?

Set HIVEMALL_HOME to absolute path when execute bin/build_xgboost.sh.

How was this patch tested?

Manual test.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage remained the same at 35.842% when pulling 0d6cafb on wangyum:HIVEMALL-28 into 38224bb on apache:master.

@myui
Copy link
Member

myui commented Jan 19, 2017

@wangyum Thank you for the contribution.

@maropu Could you review this one?

@maropu
Copy link
Member

maropu commented Jan 19, 2017

@wangyum Thanks for your work! What does this pr solve? Any issue in the current script?

@maropu
Copy link
Member

maropu commented Jan 19, 2017

@wangyum oh, I found you've already described that in the JIRA ticket. Could you write "what does this pr solve?" in this description? If you update that , LGTM. cc: @myui

@wangyum
Copy link
Member Author

wangyum commented Jan 20, 2017

@maropu I have updated the description.

@maropu
Copy link
Member

maropu commented Jan 20, 2017

LGTM cc: @myui

@asfgit asfgit closed this in ed16ca0 Jan 21, 2017
@myui
Copy link
Member

myui commented Jan 21, 2017

@wangyum merged. Thank you for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants