Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-635][BUILD] Fix travis fail to build by excluding the dependency of hbase #198

Closed
wants to merge 1 commit into from

Conversation

@runzhiwang
Copy link
Contributor

commented Aug 14, 2019

What changes were proposed in this pull request?

Fix travis fail to build by excluding the dependency of hbase.

How was this patch tested?

existed UT and IT.

@runzhiwang runzhiwang force-pushed the runzhiwang:LIVY-635 branch from facb848 to 6d9c3e7 Aug 14, 2019

@@ -39,6 +39,10 @@
<groupId>tomcat</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.hbase</groupId>

This comment has been minimized.

Copy link
@yiheng

yiheng Aug 14, 2019

Contributor

This dependency scope is not test. Not sure if this exclusion is safe

@runzhiwang runzhiwang closed this Aug 14, 2019

@runzhiwang runzhiwang reopened this Aug 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #198 into master will increase coverage by 40.44%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #198       +/-   ##
=============================================
+ Coverage     28.33%   68.77%   +40.44%     
- Complexity      343      913      +570     
=============================================
  Files           100      100               
  Lines          5679     5679               
  Branches        855      855               
=============================================
+ Hits           1609     3906     +2297     
+ Misses         3739     1216     -2523     
- Partials        331      557      +226
Impacted Files Coverage Δ Complexity Δ
...main/scala/org/apache/livy/server/LivyServer.scala 35.46% <0%> (+0.49%) 11% <0%> (ø) ⬇️
...rver/src/main/scala/org/apache/livy/LivyConf.scala 95.87% <0%> (+1.03%) 21% <0%> (+3%) ⬆️
.../main/scala/org/apache/livy/server/WebServer.scala 53.33% <0%> (+1.66%) 10% <0%> (+1%) ⬆️
...la/org/apache/livy/server/batch/BatchSession.scala 86.17% <0%> (+2.12%) 14% <0%> (ø) ⬇️
...la/org/apache/livy/utils/SparkProcessBuilder.scala 54.44% <0%> (+2.22%) 11% <0%> (+1%) ⬆️
.../scala/org/apache/livy/sessions/SessionState.scala 61.11% <0%> (+2.77%) 2% <0%> (ø) ⬇️
...e/livy/server/interactive/InteractiveSession.scala 69.11% <0%> (+3.66%) 44% <0%> (+2%) ⬆️
...org/apache/livy/server/recovery/SessionStore.scala 80% <0%> (+5%) 10% <0%> (ø) ⬇️
...ain/scala/org/apache/livy/server/JsonServlet.scala 38.46% <0%> (+5.76%) 18% <0%> (+4%) ⬆️
.../apache/livy/server/batch/CreateBatchRequest.scala 68.75% <0%> (+6.25%) 19% <0%> (+1%) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f23e0...6d9c3e7. Read the comment docs.

@jerryshao

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

CC @mgaido91 , would you please help to review. Thanks!

@jerryshao

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@runzhiwang can you please also manually verify if thriftserver can be worked without issue?

@runzhiwang

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@jerryshao It's ok to work.

@jerryshao

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

I see, thank!

@jerryshao
Copy link
Contributor

left a comment

LGTM.

@jerryshao jerryshao changed the title [LIVY-635] Fix travis fail to build by excluding the dependency of hbase [LIVY-635][BUILD] Fix travis fail to build by excluding the dependency of hbase Aug 15, 2019

@jerryshao jerryshao closed this in fb03da3 Aug 15, 2019

@mgaido91

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

LGTM too, this should be safe as AFAIK, dependencies on HBase are needed only for using HBase as a metastore, but we do not use any metastore at all. Thanks.

@runzhiwang runzhiwang deleted the runzhiwang:LIVY-635 branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.