Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-62] add test against spark integration #10462

Merged
merged 15 commits into from
Jun 12, 2018

Conversation

CodingCat
Copy link
Contributor

@CodingCat CodingCat commented Apr 9, 2018

the test would be passed only after we

  1. review and merge Allows ps to be shutdown and turn up in the same node dmlc/ps-lite#133

  2. upload the original https://s3-us-west-2.amazonaws.com/mxnet.liuyz/data/mnist/train.txt to somewhere and I update the code accordingly

the test has been run locally

image

@CodingCat CodingCat requested a review from yzhliu as a code owner April 9, 2018 03:27
$SPARK_HOME/bin/spark-submit --master spark://$HOST:7077 \
--class org.apache.mxnet.spark.example.ClassificationExample \
$SPARK_HOME/bin/spark-submit --master local[*] \
--class ml.dmlc.mxnet.spark.example.ClassificationExample \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing it back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, typos


test("run spark with MLP") {
val trainData = parseRawData(sc,
"/Users/nanzhu/code/mxnet/scala-package/spark/train.txt")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szha Any proper places can we put these testing files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update here about uploading test files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping for uploading test files @szha ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't download the file linked in the description. Could you provide a file in a publicly accessible place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way I can upload my local copy to somewhere so that you can download it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szha @piiswrong , thanks ! I have uploaded file at dmlc/web-data#63

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @szha, would you please help to uncompress and reupload, I zipped it just because github does not allow a large file...I am not sure if jenkins env has unzip command line equipped, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szha ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested I decompressed the file and put it here: http://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/mxnet-spark-test/train.txt
Why can't you decompress the file in test code?

@szha
Copy link
Member

szha commented May 21, 2018

Ping

@CodingCat
Copy link
Contributor Author

sorry about the delay, really got trapped by daily jobs these weeks, will update it this week

@CodingCat
Copy link
Contributor Author

@yzhliu want to take another look? I think the failed test is unrelated to my change

you can check the stdout of scala cpu run, Spark ML unit tests are executed

@yzhliu
Copy link
Member

yzhliu commented May 30, 2018

good to me. Just push some trivial changes, e.g., modify the commit msg, to re-trigger the CI.

@CodingCat
Copy link
Contributor Author

eh, for some reason it failed for another test suite (not scala one), and for scala one, the test was killed? (terminate called without an active exception)

@yzhliu
Copy link
Member

yzhliu commented Jun 6, 2018

@CodingCat Can you check whether the failed test is expected? Looks like it is related to what you modified.

@CodingCat
Copy link
Contributor Author

scala test was killed in the middle...not sure why....

@CodingCat
Copy link
Contributor Author

@yzhliu it passed now

zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* fix bug

* temp

* temp

* temp

* update

* update

* update

* remove debugging stubs

* remove unused

* stylistic fix

* fix typo

* Pulled down update to submodule_dir

* add test

* retrigger it

* sync 3rd party
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* fix bug

* temp

* temp

* temp

* update

* update

* update

* remove debugging stubs

* remove unused

* stylistic fix

* fix typo

* Pulled down update to submodule_dir

* add test

* retrigger it

* sync 3rd party
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants