Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Apache header on all XML #14138

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
6 participants
@lanking520
Copy link
Contributor

commented Feb 12, 2019

Description

@aaronmarkham @zachgk Adding pom files with ASF license.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested review from nswamy and yzhliu as code owners Feb 12, 2019

@zachgk

zachgk approved these changes Feb 13, 2019

@piyushghai
Copy link
Contributor

left a comment

LGTM

@ankkhedia

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@lanking520 Thanks for your contribution!

@mxnet-label-bot add [ pr-awaiting-merge ]

@szha szha merged commit 87c7add into apache:master Feb 13, 2019

12 checks passed

ci/jenkins/mxnet-validation/centos-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/centos-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/clang Job succeeded
Details
ci/jenkins/mxnet-validation/edge Job succeeded
Details
ci/jenkins/mxnet-validation/miscellaneous Job succeeded
Details
ci/jenkins/mxnet-validation/sanity Job succeeded
Details
ci/jenkins/mxnet-validation/unix-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/unix-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/website Job succeeded
Details
ci/jenkins/mxnet-validation/windows-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/windows-gpu Job succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

stephenrawls added a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019

add Apache header on all XML (apache#14138)
* add Apache header on all XML

* add deploy pom

gordon1992 pushed a commit to gordon1992/incubator-mxnet that referenced this pull request Feb 19, 2019

add Apache header on all XML (apache#14138)
* add Apache header on all XML

* add deploy pom

drivanov added a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019

add Apache header on all XML (apache#14138)
* add Apache header on all XML

* add deploy pom

@lanking520 lanking520 deleted the lanking520:addXML branch Mar 11, 2019

vdantu added a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019

add Apache header on all XML (apache#14138)
* add Apache header on all XML

* add deploy pom

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019

add Apache header on all XML (apache#14138)
* add Apache header on all XML

* add deploy pom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.