Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5.x] Handle fix_gamma in tensorrt subgraph conversion correctly #15874

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@KellenSunderland
Copy link
Contributor

commented Aug 13, 2019

Description

the current nnvm->onnx->tensorrt conversion is ignoring the fix_gamma field for batch norm layer. This commit tries to solve this particular issue by providing a way to massage params map before convert nnvm to onnx.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [ x ] Changes are complete (i.e. I finished coding on this PR)
  • [ x ] All changes have test coverage:
    • the unit test failed before and succeeded after
 a: array([[[[4.9751253]]]], dtype=float32)
 b: array([[[[0.]]]], dtype=float32)
-------------------- >> begin captured stdout << ---------------------
[[[[4.9751253]]]]
[[[[0.]]]]
--------------------- >> end captured stdout << ----------------------
----------------------------------------------------------------------
Ran 1 test in 5.820s
FAILED (failures=1)
.
----------------------------------------------------------------------
Ran 1 test in 5.513s
OK
  • [ x ] Code is well-documented:
  • [ x ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • [ x ] Add "Preprocess" step in nnvm->onnx conversion where allow modifying param map

Comments

This is a bug fix for tensor rt subgraph conversion

@KellenSunderland KellenSunderland changed the title [v1.5.x] Fix gamma 1 5 [v1.5.x] Handle fix_gamma in tensorrt subgraph conversion correctly Aug 13, 2019

@TaoLv
TaoLv approved these changes Aug 14, 2019
@pengzhao-intel
Copy link
Contributor

left a comment

LGTM

@TaoLv

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Thank you @KellenSunderland. Merging now.

@TaoLv TaoLv merged commit 6a36152 into apache:v1.5.x Aug 16, 2019

12 checks passed

ci/jenkins/mxnet-validation/centos-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/centos-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/clang Job succeeded
Details
ci/jenkins/mxnet-validation/edge Job succeeded
Details
ci/jenkins/mxnet-validation/miscellaneous Job succeeded
Details
ci/jenkins/mxnet-validation/sanity Job succeeded
Details
ci/jenkins/mxnet-validation/unix-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/unix-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/website Job succeeded
Details
ci/jenkins/mxnet-validation/windows-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/windows-gpu Job succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.