Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure: Support MKLDNN subgraph backend in tests #16117

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@adc17
Copy link
Contributor

commented Sep 8, 2019

Description

When the MKLDNN subgraph backend is enabled, subgraph assumes that any input variables have unique names. To avoid failing tests in this scenario, this PR replaces such non-unique variable names with unique ones in the Clojure test suite.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change.

Changes

  • Remove non-unique variable names from test suite.

Comments

Example error message when unique variable names are not used:

actual: org.apache.mxnet.MXNetError: [01:57:41] src/executor/graph_executor.cc:1847: Check failed: arg_names.size() == in_args_map.size() (2 vs. 1) :
Stack trace:
  [bt] (0) /tmp/mxnet4687853178926540653/libmxnet.so(+0x2ac5eb) [0x7fb8f7f495eb]
  [bt] (1) /tmp/mxnet4687853178926540653/libmxnet.so(+0x2be36e8) [0x7fb8fa8806e8]
  [bt] (2) /tmp/mxnet4687853178926540653/libmxnet.so(mxnet::Executor::Bind(nnvm::Symbol, mxnet::Context const&, std::map<std::string, mxnet::Context, std::less<std::string>, std::allocator<std::pair<std::string const, mxnet::Context> > > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, std::vector<mxnet::OpReqType, std::allocator<mxnet::OpReqType> > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, mxnet::Executor*)+0x7ad) [0x7fb8fa894c3d]
  [bt] (3) /tmp/mxnet4687853178926540653/libmxnet.so(MXExecutorBindEX+0x97b) [0x7fb8fa7cf52b]
  [bt] (4) /tmp/mxnet4687853178926540653/mxnet-scala(Java_org_apache_mxnet_LibInfo_mxExecutorBindEX+0x220) [0x7fb9297a0f00]
  [bt] (5) [0x7fb939018427]

Related to #16106.

@adc17 adc17 requested a review from gigasquid as a code owner Sep 8, 2019

@pengzhao-intel
Copy link
Contributor

left a comment

Thanks for the improvements. LGTM.

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Sep 8, 2019

CPU Performance and Quantization automation moved this from In progress to Reviewer approved Sep 9, 2019

@gigasquid
Copy link
Member

left a comment

Thanks for the fix 💯

@gigasquid gigasquid merged commit 9a9c5f8 into apache:master Sep 9, 2019

12 checks passed

ci/jenkins/mxnet-validation/centos-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/centos-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/clang Job succeeded
Details
ci/jenkins/mxnet-validation/edge Job succeeded
Details
ci/jenkins/mxnet-validation/miscellaneous Job succeeded
Details
ci/jenkins/mxnet-validation/sanity Job succeeded
Details
ci/jenkins/mxnet-validation/unix-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/unix-gpu Job succeeded
Details
ci/jenkins/mxnet-validation/website Job succeeded
Details
ci/jenkins/mxnet-validation/windows-cpu Job succeeded
Details
ci/jenkins/mxnet-validation/windows-gpu Job succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

CPU Performance and Quantization automation moved this from Reviewer approved to Done Sep 9, 2019

@adc17 adc17 deleted the adc17:adc/fix-same-data-name-error branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.