Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Factorize CUDA_KERNEL_LOOP used in CUDA kernels #16197

Merged
merged 2 commits into from Sep 27, 2019
Merged

Factorize CUDA_KERNEL_LOOP used in CUDA kernels #16197

merged 2 commits into from Sep 27, 2019

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Sep 18, 2019

Description

Make CUDA kernels use CUDA_KERNEL_LOOP macro from mxnet_op.h.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Factorize CUDA_KERNEL_LOOP

@Kh4L
Factorize CUDA_KERNEL_LOOP used in CUDA kernels
b40615e 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Sep 27, 2019
wkcn
wkcn approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wkcn wkcn merged commit dc5470c into apache:master Sep 27, 2019
@wkcn
Copy link
Member

wkcn commented Sep 27, 2019

Merged it. Thanks for your contribution : )

larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@Kh4L @larroy
Factorize CUDA_KERNEL_LOOP used in CUDA kernels (apache#16197)
941d2a5 
* Factorize CUDA_KERNEL_LOOP used in CUDA kernels

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Retrigger CI
sojiadeshina pushed a commit to sojiadeshina/incubator-mxnet that referenced this pull request Sep 30, 2019
@Kh4L @sojiadeshina
Factorize CUDA_KERNEL_LOOP used in CUDA kernels (apache#16197)
bc01a86 
* Factorize CUDA_KERNEL_LOOP used in CUDA kernels

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn approved these changes

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kh4L @wkcn @marcoabreu