Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javashell fixes #312

Merged
merged 2 commits into from Dec 2, 2017

Conversation

Projects
None yet
2 participants
@sdedic
Copy link
Member

sdedic commented Dec 2, 2017

Incidentally, I was working on NETBEANS-191 while in parallel matthiasblaesing authored 2be2f4c. I didn't sync mo fork timely, so I didn't notice the change before I started to generated the PR; sorry.

I've decided to merge the changes - licenses can be added to test data at expense of a small change to the test class. Less exceptions for rat checks.

The second part is the jar rename + license file update to include versions, to satisfy verify libs ant task.

@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Dec 2, 2017

Great, very nice, and this is needed for the 9.0 Beta since it handles licensing concerns. Merging.

@geertjanw geertjanw merged commit eda38dd into apache:master Dec 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Dec 2, 2017

Can you also close this one, if it should be closed:

https://issues.apache.org/jira/browse/NETBEANS-191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.