New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-313] Remove bootstrap.css from css.model #384

Merged
merged 22 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@geertjanw
Member

geertjanw commented Jan 23, 2018

No description provided.

geertjan added some commits Nov 4, 2017

@geertjanw

This comment has been minimized.

Show comment
Hide comment
@geertjanw

geertjanw Jan 23, 2018

Member

Will squash once approved.

Member

geertjanw commented Jan 23, 2018

Will squash once approved.

@geertjanw geertjanw requested a review from jlahoda Jan 23, 2018

@geertjanw geertjanw merged commit 2be199e into apache:master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthiasblaesing

This comment has been minimized.

Show comment
Hide comment
@matthiasblaesing

matthiasblaesing Jan 23, 2018

Contributor

Why was this merged? According to the legal FAQ:
https://www.apache.org/legal/resolved.html#category-a
MIT is whitelisted and the license terms are perfectly met. The license must stay in place and the unittests are only delivered in source - there is nothing to remove here.

Contributor

matthiasblaesing commented Jan 23, 2018

Why was this merged? According to the legal FAQ:
https://www.apache.org/legal/resolved.html#category-a
MIT is whitelisted and the license terms are perfectly met. The license must stay in place and the unittests are only delivered in source - there is nothing to remove here.

@geertjanw

This comment has been minimized.

Show comment
Hide comment
@geertjanw

geertjanw Jan 26, 2018

Member

I understand your point. However, questions have been asked about[1] this file and it seems strange to have bootstrap.css there, especially for one test only, so in this particular case, certainly not as a general rule, thought it best just to remove it.

[1]https://lists.apache.org/thread.html/5fdb996c8b25e5c48c47e4eca3942b656f690694d767d795524cc960@%3Cgeneral.incubator.apache.org%3E

Member

geertjanw commented Jan 26, 2018

I understand your point. However, questions have been asked about[1] this file and it seems strange to have bootstrap.css there, especially for one test only, so in this particular case, certainly not as a general rule, thought it best just to remove it.

[1]https://lists.apache.org/thread.html/5fdb996c8b25e5c48c47e4eca3942b656f690694d767d795524cc960@%3Cgeneral.incubator.apache.org%3E

@matthiasblaesing

This comment has been minimized.

Show comment
Hide comment
@matthiasblaesing

matthiasblaesing Jan 27, 2018

Contributor

Thanks for explaining - I agree with the assessment.

Contributor

matthiasblaesing commented Jan 27, 2018

Thanks for explaining - I agree with the assessment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment