Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Language Server Protocol client #629
This is a crude prototype of a Language Server Protocol client for NetBeans.
It currently supports:
It uses the Eclipse LSP4J (https://github.com/eclipse/lsp4j) to handle the protocol and to provide the model for the messages (I used to have a custom implementation of the protocol, but it seemed wasteful to maintain that).
There are currently two ways to use a server from the IDE:
To see the client in action using the latter approach, the following can be used:
Only to let you know: https://issues.apache.org/jira/browse/NETBEANS-180 So this PR will resolve, more or less, this ticket.
Consider importing Eclipse OSGi bundles as OSGi bundles.
So, how *exactly* do I reuse gson as an OSGi bundle? I.e. what wizard (or at worst a documentation/wiki) does/describes the steps? I was assuming c.google.guava is doing that, so I copied and adjusted that - if that's not the correct way, there needs to be specific guidelines. o.eclipse.jgit appears to use exactly the same way as guava, and many more modules do as well, so apparently the documentation on how to do things correctly is lacking?…
On Tue, Sep 11, 2018 at 8:35 AM Jaroslav Tulach ***@***.***> wrote: gson-2.7.jar is OSGi bundle. Please reuse it as OSGi bundle. Not as a wrapped module. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <0733bfa#commitcomment-30459921>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHk8ExtGjvHhBccYUso9pch_au4h3y9ks5uZ1nEgaJpZM4WirhC> .
Sep 11, 2018
Reusing existing guava seems OK. On the other hand,
OSGi bundles would better be used as OSGi bundles, not as a wrapped JARs. Edit: turns out that except missing
ide/c.google.gson/build.xml, it is already prepared as OSGi bundle.