[NETBEANS-1074] Module Review j2ee.sun.ddui #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junichi11
previously approved these changes
Aug 20, 2018
j2ee.sun.ddui/licenseinfo.xml
Outdated
|
|
||
| <licenseinfo> | ||
| <fileset> | ||
| <file>src/org/netbeans/modules/j2ee/sun/share/plan/deployment-plan.dtd</file> |
There was a problem hiding this comment.
There was a problem hiding this comment.
The DTD is the basis and DeploymentPlan is generated from it. So the IMHO correct solution would be to add the ALv2 header to the DTD file. The file is not a template, is not displayed, so should be treated as all other source files.
This was referenced Aug 20, 2018
changed license headers in five files added license headers to two file added 55 graphic files to licenseinfo.xml
thilina01
force-pushed
the
netbeans-1074-2nd-review-j2ee-sun-ddui
branch
from
0b94069
to
b0cd9bb
Compare
|
@junichi11 @matthiasblaesing Please review the changes. Thanks. :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed license headers in five files
added license headers to two file
added 55 graphic files to licenseinfo.xml