[NETBEANS-54] Module Review libs.freemarker

[vieiro]

• Added maven coordinates to external/binaries_list for freemarker 2.3.19 (BSD 3?)
• Added headers to two source files (FreemarkerEngine.java & FreemarkerFactory.java) and to one test file.
• All unit tests passing.
• Not adding license headers to the following test files (as some tests would fail):
  • ./test/unit/data/golden/GeneratedMethodBody.java
  • ./test/unit/data/golden/ClassWithoutReplacements.java
  • ./test/unit/data/golden/GeneratedMethodBody2.java
  • ./test/unit/data/golden/ForceNoReplacements.java
  • ./test/unit/data/golden/SimpleReplacements.java
  • ./test/unit/data/licenseheader.txt
  • ./test/unit/data/templates/GeneratedMethodBody.java
  • ./test/unit/data/templates/ClassWithoutReplacements.java
  • ./test/unit/data/templates/SimpleReplacements.java

[matthiasblaesing]

This is in the license:

2. The end-user documentation included with the redistribution, if any, must
   include the following acknowlegement:
   "This product includes software developed by the
   Visigoth Software Society (http://www.visigoths.org/)."
   Alternately, this acknowlegement may appear in the software itself, if and
   wherever such third-party acknowlegements normally appear.

I would this include a "-notice" file, that in the end should end up in the apache NOTICE file. From my reading this is similar to the apache NOTICE file, that needs to be redistributed.

[matthiasblaesing]

I would not go for the full license in the notice. I would just add the required part (see section 2 of the license):

This product includes software developed by the
Visigoth Software Society (http://www.visigoths.org/).

For updates please also squash the changes together - there will now be at least four changeset for more or less one change.

[matthiasblaesing]

Thank you - I squashed your changes together and added an exclusion in the rat report for the test-data.

[vieiro]

Thank you, I'll try to add those test files to the exclusion list myself in future PRs.