Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/libc/stdlib: Implement mkdtemp(3) syscall #1828

Merged
merged 3 commits into from Sep 19, 2020

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Sep 17, 2020

Summary

libs/libc/stdlib: Implement mkdtemp(3) syscall

See the reference here:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkdtemp.html

libs/libc/stdio: correct the prototype of mktemp(3)

From:   int       mktemp(FAR char *path_template);
To:     FAR char *mktemp(FAR char *path_template);

See the reference here:
https://pubs.opengroup.org/onlinepubs/009695399/functions/mktemp.html

Impact

Temporary name, file or directory create

Testing

API Testing

@anchao
Copy link
Contributor Author

anchao commented Sep 17, 2020

##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/libs/libc/stdio/lib_tmpnam.c:84:19: error: Mixed case identifier found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/libs/libc/stdio/lib_tmpnam.c:91:14: error: Mixed case identifier found
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/libs/libc/stdio/lib_tmpnam.c:91:37: error: Mixed case identifier found

mixed case found on ci-check, let us ignore this error

Change-Id: Id12ed4241698c8d4426907ca72eef334894ee1f3
Signed-off-by: chao.an <anchao@xiaomi.com>
From:   int       mktemp(FAR char *path_template);
To:     FAR char *mktemp(FAR char *path_template);

See the reference here:
https://pubs.opengroup.org/onlinepubs/009695399/functions/mktemp.html

Signed-off-by: chao.an <anchao@xiaomi.com>
See the reference here:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkdtemp.html

Change-Id: I49081ecafc011a843e6067b1118b53bf65d4418b
Signed-off-by: chao.an <anchao@xiaomi.com>
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiaoxiang781216 xiaoxiang781216 merged commit 216c33a into apache:master Sep 19, 2020
@btashton btashton added this to To-Add in Release Notes - 10.0.0 Oct 14, 2020
@btashton btashton moved this from To-Add to Added in Release Notes - 10.0.0 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants