xtensa/esp32: Refactor register access functions on SPI driver #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR intends to refactor the way that registers are accessed in the ESP32 SPI driver.
The motivation for this refactor are:
esp32_spi_get_regandesp32_spi_set_regwrapper functions in favor of a direct call togetreg32andputreg32, respectively.SPI_<REG_NAME>_REG(i)definitions which already resolve the final register address for a given SPI peripheral IDi.Impact
No functional changes to the ESP32 SPI driver.
Testing
esp32-wrover-kitwith a yet to be upstreamed SPI LCD driver.