Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/devif: fix devif loopback #7746

Merged
merged 1 commit into from Dec 1, 2022
Merged

Conversation

wengzhe
Copy link
Contributor

@wengzhe wengzhe commented Dec 1, 2022

Summary

devif_loopback needs to be applied on l2 data, and was broken by commit below, now fix it.

| commit 8850dee
| Author: chao an anchao@xiaomi.com
| Date: Sun Nov 27 03:31:07 2022 +0800
|
| net/devif: move preprocess of txpoll into common code
|
| Signed-off-by: chao an anchao@xiaomi.com

Signed-off-by: Zhe Weng wengzhe@xiaomi.com

Impact

  • Fix logic when calling devif_loopback on ETHERNET devices.

Testing

  • Tested on sim with 2 tap devices, ping from host connected with eth0 to ip assigned to eth1, will work like following:
    • host -> eth0 -> forward -> eth1 -> loopback on eth1 -> eth1 icmp reply -> still loopback on eth1 -> forward -> eth0 -> host

devif_loopback needs to be applied on l2 data, and was broken by commit below, now fix it.

| commit 8850dee
| Author: chao an <anchao@xiaomi.com>
| Date:   Sun Nov 27 03:31:07 2022 +0800
|
|     net/devif: move preprocess of txpoll into common code
|
|     Signed-off-by: chao an <anchao@xiaomi.com>

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 3aac6a1 into apache:master Dec 1, 2022
@jerpelea jerpelea added this to To-Add in Release Notes - 12.0.0 Dec 29, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.0.0 Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants