Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Node.js v12 runtime. #126

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
3 participants
@jthomas
Copy link
Member

commented May 1, 2019

  • Re-used nodejs10Action directory for new v12 runtime.
  • Re-wrote the README to be contain instructions which actually work!

@jthomas jthomas requested a review from csantanapr May 1, 2019

@rabbah

rabbah approved these changes May 1, 2019

@@ -35,6 +35,7 @@ tasks.withType(Test) {

dependencies {
compile "org.scala-lang:scala-library:${gradle.scala.version}"
// testCompile 'org.scalatest:scalatest_2.12:3.0.5'

This comment has been minimized.

Copy link
@dgrove-oss

dgrove-oss May 1, 2019

Contributor

Inadvertent change?

This comment has been minimized.

Copy link
@jthomas

jthomas May 7, 2019

Author Member

Good catch - let me fix that.

Adding Node.js v12 runtime.
- Re-used nodejs10Action directory for new v12 runtime.
- Re-wrote the README to be contain instructions which actually work!

@jthomas jthomas force-pushed the jthomas:master branch from 38822cc to f1d6b0a May 7, 2019

@jthomas jthomas merged commit 386b13d into apache:master May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jthomas added a commit to jthomas/incubator-openwhisk-runtime-nodejs that referenced this pull request May 7, 2019

jthomas added a commit to jthomas/incubator-openwhisk-runtime-nodejs that referenced this pull request May 7, 2019

jthomas added a commit that referenced this pull request May 7, 2019

Update Travis file to build & push Node.js v12 image to Docker Hub. (#…
…128)

* Update Travis file to build & push Node.js v12 image to Docker Hub.

Related to #126

* Fixing string formatting causing travis parsing error!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.