Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tuning Dockerfile for alpine 'scala' image #3408

Closed
wants to merge 1 commit into from

Conversation

jonpspri
Copy link
Contributor

@jonpspri jonpspri commented Mar 7, 2018

Linting-type improvements to the alpine 'scala' Dockerfile. No functional changes.

Description

Two changes to the Dockerfile to improve reliability and maintainability:

  1. apk add --update --no-cache reduces command lines and image size by doing all-in-one and not storing a cache on the image. (I know the rm is still there -- belt-and-suspenders for now)
  2. Curling to a temporary file and then untarring ensures all return codes are captured, otherwise a
    curl file in the pipeline would cause an inscrutable failure of the following tar.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@rabbah rabbah added the review Review for this PR has been requested and yet needs to be done. label Mar 20, 2018
@jonpspri
Copy link
Contributor Author

As much as I adore hadolint, I'm closing this because Oracle seems to have tipped my hand.

@jonpspri jonpspri closed this Mar 24, 2018
@jonpspri jonpspri deleted the cleanup-scala-dockerfile branch April 19, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Review for this PR has been requested and yet needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants