Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating runtimes to include new Node.js v12 image. #4472

Merged
merged 3 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@jthomas
Copy link
Member

commented May 7, 2019

Description

Updated runtimes definition to include new Node.js v12 runtime image.

  • Updated runtimes manifest
  • Added API documentation
  • Minor updates to docs
  • Added automated test case

Related issue and scope

apache/incubator-openwhisk-runtime-nodejs#124

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.
Updating runtimes to include new Node.js v12 image.
- Updated runtimes manifest
- Added API documentation
- Minor updates to docs
- Added automated test case

@jthomas jthomas requested a review from csantanapr May 7, 2019

Show resolved Hide resolved ansible/files/runtimes.json Outdated
@@ -43,7 +43,7 @@ and demonstrate how to bundle multiple JavaScript files and third party dependen

The CLI automatically infers the type of the action by using the source file extension.
For `.js` source files, the action runs by using a Node.js runtime. You may specify
the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:10`, `--kind nodejs:8`, or `--kind nodejs:6`
the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:12`, `--kind nodejs:10`, `--kind nodejs:8`, or `--kind nodejs:6`

This comment has been minimized.

Copy link
@rabbah

rabbah May 7, 2019

Member

remove nodejs:6?

This comment has been minimized.

Copy link
@jthomas

jthomas May 8, 2019

Author Member

I'm not sure about this. It is still available in the project (for back compat reasons atm). Until it's removed - which is another PR, I think we should keep it in the docs?

This comment has been minimized.

Copy link
@csantanapr

csantanapr May 8, 2019

Contributor

Remove it from the docs now

@@ -222,7 +222,7 @@ zip -r action.zip *
wsk action create packageAction --kind nodejs:10 action.zip
```

When creating an action from a `.zip` archive with the CLI tool, you must explicitly provide a value for the `--kind` flag by using `nodejs:10`, `nodejs:8` or `nodejs:6`.
When creating an action from a `.zip` archive with the CLI tool, you must explicitly provide a value for the `--kind` flag by using `nodejs:12`, `nodejs:10`, `nodejs:8` or `nodejs:6`.

This comment has been minimized.

Copy link
@rabbah

rabbah May 7, 2019

Member

same re 6.

@@ -29,7 +29,7 @@ Concurrent activation processing within the same action container can be enabled

* enable the akka http client at invoker config
* e.g. CONFIG_whisk_containerPool_akkaClient=true
* use a kind that supports concurrency (currently only `nodejs:10`, `nodejs:8` and `nodejs:6`)
* use a kind that supports concurrency (currently only `nodejs:12`, `nodejs:10`, `nodejs:8` and `nodejs:6`)

This comment has been minimized.

Copy link
@rabbah

rabbah May 7, 2019

Member

remove 6.

@csantanapr
Copy link
Contributor

left a comment

/lgtm

@csantanapr

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@jthomas
Conflicting files:
ansible/files/runtimes.json

@jthomas jthomas merged commit 4df3d09 into apache:master May 15, 2019

2 checks passed

continuous-integration/jenkins-ci/pr SUCCESS
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.