Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc that elide_attributes_filter has specific risks #102

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 1 comment
Closed

doc that elide_attributes_filter has specific risks #102

GoogleCodeExporter opened this issue Apr 6, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

One can use [attr="value"] selectors for any attribute.  This means
that unless elide_attributes is inspecting and/or rewriting CSS, it
cannot remove any attributes, ever, without risking breaking someone's
CSS.

Original issue reported on code.google.com by jmara...@google.com on 19 Nov 2010 at 3:31

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

This risk is now documented explicitly:

http://code.google.com/speed/page-speed/docs/filter-attribute-elide.html

Original comment by jmara...@google.com on 19 Nov 2010 at 11:28

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.