New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS optimizations are conservative in the presence of extra attributes #104

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What is the expected output?   All CSS combined or cache-extended
What do you see instead?  Some CSS files are left unoptimized
What version of the product are you using:  X-Mod-Pagespeed 0.9.8.1-215
Which version of Apache?  Apache/2.2.3 (CentOS),  X-Powered-By  PHP/5.1.6
Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.

http://www.cloudtech.org/

These links are not optimized because mod_pagespeed ignores any 'link' tags 
with unexpected attributes.  It should just leave them alone -- actually 
CSS-combining should probably *not* combine CSS links with distinct IDs.  
However that should not prevent cache extension.

<link rel='stylesheet' id='codecolorer-css' 
href='http://www.cloudtech.org/wp-content/plugins/codecolorer/codecolorer.css?ve
r=0.9.8' type='text/css' media='screen'/>
<link rel='stylesheet' id='wp_dlmp_styles-css' 
href='http://www.cloudtech.org/wp-content/plugins/download-monitor/page-addon/st
yles.css?ver=3.0.1' type='text/css' media='all'/>

Original issue reported on code.google.com by jmara...@google.com on 20 Nov 2010 at 1:50

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 20 Nov 2010 at 1:51

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Same observed with charset="" attribute.

Original comment by webmas...@clubsilver.org on 10 Apr 2011 at 9:59

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

The restriction for combine_css still remains, but combine_css and rewrite_css 
no longer are affected by extra 'link' attributes.

Original comment by jmara...@google.com on 6 May 2011 at 2:38

  • Changed state: Fixed
  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment