Source maps set ?PageSpeed=off for .pagespeed. sources

[GoogleCodeExporter]

From jefftk:

I'm debugging an issue with santelab.pl and I noticed a
probably-unrelated bug with source maps.  They have outline_javascript
turned on, which is generating:

    http://santelab.pl/_,Mjo.Q9nQ-Do8TV.js.pagespeed.jm.ojQMh0-c2n.js

At the end of that script we have:

    sourceMappingURL=http://santelab.pl/_,Mjo.Q9nQ-Do8TV.js.pagespeed.sm.M3SLgWAY9W.map

Fetching that map, I get:

    {"mappings":"AAAA,o/BACA,meACA,mEACA,wfACA,2fACA,sdAEA",
      "names":[],
      "sources":["http://santelab.pl/_.pagespeed.jo.Q9nQ-Do8TV.js?PageSpeed=off"],
      "version":3}

The part that looks broken is the source url.  When I try to fetch it
I get a 404, which isn't surprising given that an outlined js file
with PageSpeed off doesn't make much sense.

Original issue reported on code.google.com by sligocki@google.com on 21 Jan 2015 at 4:48

[GoogleCodeExporter]

Hm, actually, this doesn't seem specific to OutlineJS. This same problem would 
happen to any filter which manipulated JS before rewrite_js (Although that may 
only be OutlineJS currently)

In this case, we are outlining to 
http://santelab.pl/_.pagespeed.jo.Q9nQ-Do8TV.js and then minifying that to 
http://santelab.pl/_,Mjo.Q9nQ-Do8TV.js.pagespeed.jm.ojQMh0-c2n.js .

In the normal flow (where the input to rewrite_js is non-pagespeed file), we 
need to add ?PageSpeed=off in order to avoid IPRO rewriting it. However, in the 
case that the input is a .pagespeed. resource, we should not be adding 
?PageSpeed=off, because that doesn't make sense and IPRO will not modify 
.pagespeed. resources.

Original comment by sligocki@google.com on 21 Jan 2015 at 5:09

• Changed title: source maps should not set ?PageSpeed=off for .pagespeed. resources

[GoogleCodeExporter]

Are you sure the current state doesn't work?  I know it doesn't make a lot of 
sense to ask for a pagespeed resource with ?PageSpeed=off but it will actually 
work:

http://modpagespeed.com/rewrite_javascript.js.pagespeed.jm.1o978_K0_L.js?PageSpe
ed=off

What's the user-visible symptom with outlined JS source maps?

Original comment by jmara...@google.com on 21 Jan 2015 at 5:13

[GoogleCodeExporter]

This issue was closed by revision r4529.

Original comment by sligocki@google.com on 27 Jan 2015 at 6:15

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by sligocki@google.com on 27 Jan 2015 at 6:25

• Added labels: Milestone-v33, release-note