Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious DownstreamCacheRebeaconingKey Warning #1060

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments
Closed

Spurious DownstreamCacheRebeaconingKey Warning #1060

GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

* What steps will reproduce the problem?
1. Enable Downstream Caching

* What is the expected output?

No warnings.

* What do you see instead?

Warning: You seem to have downstream caching configured on your server. 
DownstreamCacheRebeaconingKey should also be set for this to work correctly. 
Refer to 
https://developers.google.com/speed/pagespeed/module/downstream-caching#beaconin
g for more details.


This was reported on the ngx_pagespeed mailing list: 
https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/nz_ruhHDZ0I

Looking at the code I don't think we're issuing this warning correctly and we 
need to guard it with an explicit check for whether 
DownstreamCacheRebeaconingKey is configured.

Original issue reported on code.google.com by jefftk@google.com on 30 Mar 2015 at 12:33

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Reproduced:

1. start testing instance of ngx_pagespeed
2. run:

   http_proxy=localhost:8051 \
     curl -D- \
          -H 'User-Agent: Chrome/100' \
          -H 'PS-ShouldBeacon: random_rebeaconing_key' \
          http://downstreamcacherebeacon.example.com/mod_pagespeed_test/downstream_caching.html?PageSpeedFilters=lazyload_images

Original comment by jefftk@google.com on 30 Mar 2015 at 1:45

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

I think we just need to guard the message with 
"!driver->options()->IsDownstreamCacheRebeaconingKeyConfigured()".  Patch out 
for review now.

Original comment by jefftk@google.com on 30 Mar 2015 at 1:55

  • Changed state: Started
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jefftk@google.com on 30 Mar 2015 at 7:45

  • Changed state: Fixed
crowell added a commit that referenced this issue May 11, 2015
backport change from 53add3a
Remove about not having a downstream cache rebeaconing key configured.
Fixes #1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant