Spurious DownstreamCacheRebeaconingKey Warning

[GoogleCodeExporter]

* What steps will reproduce the problem?
1. Enable Downstream Caching

* What is the expected output?

No warnings.

* What do you see instead?

Warning: You seem to have downstream caching configured on your server. 
DownstreamCacheRebeaconingKey should also be set for this to work correctly. 
Refer to 
https://developers.google.com/speed/pagespeed/module/downstream-caching#beaconin
g for more details.


This was reported on the ngx_pagespeed mailing list: 
https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/nz_ruhHDZ0I

Looking at the code I don't think we're issuing this warning correctly and we 
need to guard it with an explicit check for whether 
DownstreamCacheRebeaconingKey is configured.

Original issue reported on code.google.com by jefftk@google.com on 30 Mar 2015 at 12:33

[GoogleCodeExporter]

Reproduced:

1. start testing instance of ngx_pagespeed
2. run:

   http_proxy=localhost:8051 \
     curl -D- \
          -H 'User-Agent: Chrome/100' \
          -H 'PS-ShouldBeacon: random_rebeaconing_key' \
          http://downstreamcacherebeacon.example.com/mod_pagespeed_test/downstream_caching.html?PageSpeedFilters=lazyload_images

Original comment by jefftk@google.com on 30 Mar 2015 at 1:45

[GoogleCodeExporter]

I think we just need to guard the message with 
"!driver->options()->IsDownstreamCacheRebeaconingKeyConfigured()".  Patch out 
for review now.

Original comment by jefftk@google.com on 30 Mar 2015 at 1:55

• Changed state: Started

[GoogleCodeExporter]

Original comment by jefftk@google.com on 30 Mar 2015 at 7:45

• Changed state: Fixed