purging fails if ModPagespeed=off in global config #1077
Comments
I can see exactly what the problem is, and a fix should not be difficult. The problem is that InstawebHandler::instaweb_handler does: if (options_->enabled()) { Here the options_ come from the ServerContext (aka VHOST) and not the options computed dynamically per-request based on .htaccess, or (for that matter) request headers or query-params. |
I didn't fully understand your answer.. Are you saying I should put the ------ Original Message ------
|
The workaround you already put in place is fine (turn MPS on in the root config) although it's not what you want for other reasons. A better remedy -- and the one we test for -- is to define your hosts in VirtualHost blocks rather than an .htaccess file. I'm imagining there are reasons you didn't do that (e.g. the number of hosts is large or dynamic). The best remedy is for us to ship a fix to this problem, which should be trivial -- I've already done it and just need to test it, get it reviewed, and it will be in a patch release. You could also apply the patch yourself and do a rebuild if that helped. Sorry for missing this obvious testcase! |
When possible, it is preferable to put the entire configuration in a vhost All of that overhead is small compared with image-optimization. It might -Josh On Wed, May 13, 2015 at 1:31 PM, lesfen notifications@github.com wrote:
|
Fantastic.. I just finished moving the entire contents of .htaccess The only bad ratio I have is for the LRU. 80%misses 5% hits and 15% Les Fenison ------ Original Message ------
|
Incorporate more config data into the key used for sharing CachePath objects so that we don't share cache objects between vhosts that have purging enabled/disabled, and we don't share between those that have different cache-flush filenames. #1077
Sorry, this issue is still open for nginx. |
When modpagespeed is set to off in the global config and only enabled for some virtual domains, purging will not work.
To duplicate...
The item will show up in /var/cache/mod_pagespeed/cache.purge (assuming that is where your cache is). But the item will not show up in the gui and the purge will not happen.
Then set ModPagespeed on in the global and test again and purging works normally.
The text was updated successfully, but these errors were encountered: