-
Notifications
You must be signed in to change notification settings - Fork 155
Critical images js doesn't play well with display
#1087
Comments
I think this was reported before, but I don't see the bug looking now. |
I have a CL sitting around to fix this that needs tests written. My Misplaced the bug number, which I used to have open in a tab. Grrr... No -Jan On Thu, May 28, 2015 at 9:25 AM, Jeff Kaufman notifications@github.com
|
This should be fixed; I've moved the script load to or to top of page if there's no head. |
closed by 0184daf |
display
display
On ngx-pagespeed-discuss someone said their page was intermittently getting js plastered across it on mobile. Specifically, PageSpeed was turning:
into:
Which looked like:
Here's a static copt with the same problem: http://www.jefftk.com/repro-bad-js-issue2?PageSpeed=off
Here's a simplified page with the same problem: http://www.jefftk.com/repro-bad-js-issue3?PageSpeed=off
The basic issue is that we're inserting JS inside a tag that they've set all the children of to
display: inline-block
.A fix is to put
display:none
on the js we insert: http://www.jefftk.com/repro-bad-js-issue4?PageSpeed=offAnother fix would be to insert the JS with base64
src=
inlining instead (haven't tried this).The text was updated successfully, but these errors were encountered: