New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set MessageBufferSize to 0 #1109

Closed
jeffkaufman opened this Issue Jul 16, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Jul 16, 2015

If you set MessageBufferSize to 0 you'll get a syntax error and PageSpeed can't start. Which is bad, since setting it to 0 is the documented way to disable it.

The problem is my cleanup cl from 2014-06-18 that includes MessageBufferSize in a list of directives that take n > 0 when it should be n >= 0 in this case.

@jeffkaufman jeffkaufman self-assigned this Jul 16, 2015

jeffkaufman added a commit that referenced this issue Jul 28, 2015

options: allow MessageBufferSize and Num(Expensive)RewriteThreads to …
…be 0

These options have documented meanings for 0, but on 2014-06-18 we added a check that they be >0.  Relax that restriction.

Fixes #1109

@jeffkaufman jeffkaufman changed the title can't set MessageBufferSize to 0 Can't set MessageBufferSize to 0 Jul 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment