Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Don't accumulate waveforms if no one is looking at them #1127

Closed
jmarantz opened this issue Aug 27, 2015 · 2 comments
Closed

Don't accumulate waveforms if no one is looking at them #1127

jmarantz opened this issue Aug 27, 2015 · 2 comments

Comments

@jmarantz
Copy link
Contributor

Currently we collect a lot of waveform data in mod_pagespeed that has a non-trivial cost in memory & cpu. However we don't even have a live admin-page tab to show them. (at one point in the past we did, but it did not survive a refactor).

So we might as well not collect them until they are shown.

@jeffkaufman
Copy link
Contributor

@jmarantz Did 53be049 fix this?

@jmarantz
Copy link
Contributor Author

jmarantz commented Oct 4, 2016

yes

@jmarantz jmarantz closed this as completed Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants