Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accumulate waveforms if no one is looking at them #1127

Closed
jmarantz opened this issue Aug 27, 2015 · 2 comments
Closed

Don't accumulate waveforms if no one is looking at them #1127

jmarantz opened this issue Aug 27, 2015 · 2 comments

Comments

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Aug 27, 2015

Currently we collect a lot of waveform data in mod_pagespeed that has a non-trivial cost in memory & cpu. However we don't even have a live admin-page tab to show them. (at one point in the past we did, but it did not survive a refactor).

So we might as well not collect them until they are shown.

@jeffkaufman
Copy link
Contributor

@jeffkaufman jeffkaufman commented Oct 3, 2016

@jmarantz Did 53be049 fix this?

@jmarantz
Copy link
Contributor Author

@jmarantz jmarantz commented Oct 4, 2016

yes

@jmarantz jmarantz closed this Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants