Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp transcoding does not work for MapProxyDomain resources written in-place. #1149

Closed
jmarantz opened this issue Oct 6, 2015 · 1 comment
Closed
Assignees

Comments

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Oct 6, 2015

If you have
MapProxyDomain mps_host/origin origin_host/static
a request for:
http://mps_host/origin/foo.jpg
will not be transcoded to webp.

This might seem like an odd case, because why would a browser request http://mps_host/origin/foo.jpg? It works fine with MapProxyDomain when there is URL rewriting in HTML, in which case the webp request is encoded in the rewritten URL and it is not rewritten in-place.

However you can in theory construct an HTML page with MapProxyDomain and a bunch of references to external images via their manually rewritten proxied location, say, as a demo showing the benefits of passing those images through MPS.

@jmarantz jmarantz self-assigned this Oct 6, 2015
jmarantz added a commit that referenced this issue Oct 9, 2015
#1149

Note that IPRO+MPD was working (and optimizing) in MPS; it just wasn't
getting the right UA/Accept-header bits propagated into the
request_properties, so webp transcoding didn't happen.
@jeffkaufman
Copy link
Contributor

@jeffkaufman jeffkaufman commented Oct 23, 2015

Fixed by 52f0d46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants