Skip to content

/ incubator-pagespeed-mod

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow doesn't apply to defer_javascript #1173

Closed
aminsabet opened this issue Nov 9, 2015 · 0 comments
Closed

Disallow doesn't apply to defer_javascript #1173

aminsabet opened this issue Nov 9, 2015 · 0 comments

Comments

@aminsabet
Copy link

@aminsabet aminsabet commented Nov 9, 2015

If I use this:

ModPagespeedEnableFilters defer_javascript

ModPagespeedDisallow "*/jquery-ui-1.8.2.custom.min.js"

The disallow prevents rewriting of the specified javascript but doesn't prevent it from being deferred.

Would be nice to have a way to make defer exceptions for certain scripts in the pagespeed.conf, whether by using disallow or another setting.
@morlovich morlovich self-assigned this Nov 9, 2015
morlovich added a commit that referenced this issue Nov 10, 2015
@morlovich
Honor disallow in defer_js
Loading status checks…
53e9fca 
See: #1173
@morlovich morlovich mentioned this issue Nov 10, 2015
Merged
morlovich added a commit that referenced this issue Nov 10, 2015
@morlovich
Merge pull request #1177 from pagespeed/morlovich-107417631
Loading status checks…
766a72d 
Honor disallow in defer_js
See: #1173
@morlovich morlovich closed this Nov 10, 2015
@jeffkaufman jeffkaufman changed the title ModPagespeedDisallow doesn't prevent defer javascript Disallow doesn't apply to defer_javascript Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aminsabet @morlovich
You can’t perform that action at this time.