New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize Critical CSS writes a mixture of optimized and unoptimized content #1187

Closed
jeffkaufman opened this Issue Nov 13, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Nov 13, 2015

Fixed in 98ffc6e

@eldk

This comment has been minimized.

Copy link
Contributor

eldk commented Dec 15, 2015

Hello,
I have switch to 1.10.33.0-beta.
On first run, one css file (sometimes three, sometimes four are requested for one page) is missing, so some page styling are not applied.
After a few request on the page with the browser, styles are good (no more mixture)

I use ModPagespeedRewriteLevel OptimizeForBandwidth
with those optional filters :
ModPagespeedEnableFilters lazyload_images,convert_to_webp_lossless,combine_css,trim_urls,remove_comments,collapse_whitespace,prioritize_critical_css,insert_dns_prefetch,combine_javascript,defer_javascript

  • ipro (enable by default) and loadfromfiles (not for CSS) for images.

This was set prior to migration to MPS 1.10 and page was good on first run
ModPagespeedCssInlineMaxBytes 10240
With same option now, one CSS file (that was the target of ModPagespeedCssInlineMaxBytes 10240) does not load on first page request.
<link rel="stylesheet" href="thelongestfrom2048bytes.css"> disappeared from html source return by mod_pagespeed on the first run and stylesheet is not loaded.

Greatings,

Eric

@eldk

This comment has been minimized.

Copy link
Contributor

eldk commented Dec 15, 2015

Ok solved : remove combine_css from ModPagespeedEnableFilters and all goes good.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Dec 15, 2015

That's a workaround, and I'm glad that fixed your problem, but this is still a bug and something we need to fix. CSS files should never be dropped because that breaks pages. Moved to a new bug: #1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment