Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File cache entries are read in 10k chunks #1203

Closed
jeffkaufman opened this issue Dec 8, 2015 · 4 comments
Closed

File cache entries are read in 10k chunks #1203

jeffkaufman opened this issue Dec 8, 2015 · 4 comments

Comments

@jeffkaufman
Copy link
Contributor

@jeffkaufman jeffkaufman commented Dec 8, 2015

We could use a stat and read whole files at once, but currently we read files in fixed size chunks. Since we need the whole file in memory, this is pretty wasteful.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Dec 8, 2015

Fixed in 56e4c8d

@jeffkaufman jeffkaufman closed this Dec 8, 2015
@keesspoelstra
Copy link
Contributor

@keesspoelstra keesspoelstra commented Dec 8, 2015

What about side effects/behavior with RewriteLevel PassThrough?

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Dec 8, 2015

@keesspoelstra Huh? I wouldn't expect 56e4c8d to affect passthrough, because that shouldn't be using the file cache at all.

@keesspoelstra
Copy link
Contributor

@keesspoelstra keesspoelstra commented Dec 9, 2015

Wrong issue, should be a remark for 973, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants