Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minification failes when font: shorthand #121

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 9 comments
Closed

CSS minification failes when font: shorthand #121

GoogleCodeExporter opened this issue Apr 6, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?

1. Add a "color: inherit" CSS rule to a <link>ed CSS file
2. The css_filter_parse_failures count increases on each page load


What is the expected output? What do you see instead?

CSS minification is expected. No minification of the CSS takes place.


What version of the product are you using (please check X-Mod-Pagespeed
header)?

0.9.10.1-250


On what operating system?

Ubuntu 10.04 LTS and Ubuntu 10.10


Which version of Apache?

Apache 2.2


Which MPM?

Prefork


Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.

The CSS 2 standard allows a colour value of 'inerit' to be used as documented 
in http://www.w3.org/TR/CSS2/colors.html

Original issue reported on code.google.com by testmoot...@gmail.com on 30 Nov 2010 at 5:03

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Additional information.

Tested on: http://www.affiliatefundamentals.co.uk/
CSS file: http://www.affiliatefundamentals.co.uk/css/base.css

Original comment by testmoot...@gmail.com on 30 Nov 2010 at 5:05

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 1 Dec 2010 at 11:44

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Yes, I can confirm that this causes the parser to fail, I'm looking into it, 
thanks.

Original comment by sligocki@google.com on 1 Dec 2010 at 7:30

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Actually, my test was flawed, { color: inherit } does work for me. I think what 
is causing your CSS to fail to parse is actually the font: shorthand property, 
which our parser expands into all constituent parts. This is an issue I've 
known about for a while. I'll set this bug to track dealing with it.

Original comment by sligocki@google.com on 1 Dec 2010 at 9:04

  • Changed title: CSS minification failes when font: shorthand
  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 2 Dec 2010 at 5:59

  • Changed state: Started
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fixed in trunk

Original comment by sligocki@google.com on 3 Dec 2010 at 6:05

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Just to clarify, this was fixed in r270 and Jan says it will be in the release 
coming out soon.

Original comment by sligocki@google.com on 3 Dec 2010 at 3:13

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Thanks for looking into the issue.

I've manually split the the font: but still don't see minification. This is 
also true, however, if I remove the color: inherit which I originally suspected 
as the culprit, so perhaps something else is playing a hand here.

I'll wait for the next .deb release and see how I get on; fingers crossed!

Original comment by testmoot...@gmail.com on 3 Dec 2010 at 4:09

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Alright, the issue is "list-style-type: none", none is not being accepted as a 
valid value here, but it is valid (See 
http://www.w3.org/TR/CSS2/generate.html#list-style), so I'm filing this as a 
new bug 128.

Original comment by sligocki@google.com on 3 Dec 2010 at 7:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.