New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS files with OptimizeForBandwith + combine_css #1215

Closed
jeffkaufman opened this Issue Dec 15, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Dec 15, 2015

Moved from #1187 (comment)

I have switch to 1.10.33.0-beta.
On first run, one css file (sometimes three, sometimes four are requested for one page) is missing, so some page styling are not applied.
After a few request on the page with the browser, styles are good (no more mixture)

I use ModPagespeedRewriteLevel OptimizeForBandwidth
with those optional filters :
ModPagespeedEnableFilters lazyload_images,convert_to_webp_lossless,combine_css,trim_urls,remove_comments,collapse_whitespace,prioritize_critical_css,insert_dns_prefetch,combine_javascript,defer_javascript

ipro (enable by default) and loadfromfiles (not for CSS) for images.
This was set prior to migration to MPS 1.10 and page was good on first run
ModPagespeedCssInlineMaxBytes 10240
With same option now, one CSS file (that was the target of ModPagespeedCssInlineMaxBytes 10240) does not load on first page request.

disappeared from html source return by mod_pagespeed on the first run and stylesheet is not loaded.
@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Dec 15, 2015

Hacked gtest that reproduces (and fails): https://gist.github.com/oschaaf/15a9a429867ee18ea622

morlovich added a commit that referenced this issue Dec 17, 2015

Quickfix for URL preservation + combine_css conflict:
for now disable combine_css. Proper resolution (which will
make it win in some circumstances) will be a follow up,
but likely quite a bit more complex.
Note that combine_js isn't affected by this since it makes an entirely
new script element for combination (as well as new ones for evals), rather
than using the one from the first input.

Addresses Otto's reduction in issue #1215

@jeffkaufman jeffkaufman changed the title Missing CSS files Missing CSS files with OptimizeForBandwith + combine_css Dec 17, 2015

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Dec 17, 2015

Fixed with 55e0962

morlovich added a commit that referenced this issue Dec 17, 2015

Quickfix for URL preservation + combine_css conflict:
for now disable combine_css. Proper resolution (which will
make it win in some circumstances) will be a follow up,
but likely quite a bit more complex.
Note that combine_js isn't affected by this since it makes an entirely
new script element for combination (as well as new ones for evals), rather
than using the one from the first input.

Addresses Otto's reduction in issue #1215
@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Jan 21, 2016

This applies to 1.9.x as well too, right?

@morlovich

This comment has been minimized.

Copy link
Contributor

morlovich commented Jan 21, 2016

Probably best to just run the test to see?

crowell added a commit that referenced this issue Jan 21, 2016

Quickfix for URL preservation + combine_css conflict:
apply change from 55e0962

for now disable combine_css. Proper resolution (which will
make it win in some circumstances) will be a follow up,
but likely quite a bit more complex.
Note that combine_js isn't affected by this since it makes an entirely
new script element for combination (as well as new ones for evals), rather
than using the one from the first input.

Addresses Otto's reduction in issue #1215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment